-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgraphs integration #198
Conversation
- Added interfaces for NeverminedEvents - unit tests passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, but nice integration, thanks 👍
) { | ||
// Check if the event already happened and return that instead | ||
// before subscribing | ||
const events = await this.getPastEvents(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will be of great use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. Although you should always prefer once
to getPastEvents
because it works differently with the graph because the indexer node always lags behind a bit
Description
Is this PR related with an open issue?
Related to Issue #
Types of changes
Checklist:
Funny gif